wgtmac commented on code in PR #102:
URL: https://github.com/apache/iceberg-cpp/pull/102#discussion_r2100356081


##########
src/iceberg/schema_util.h:
##########
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#pragma once
+
+#include <any>
+#include <memory>
+#include <string>
+#include <variant>
+#include <vector>
+
+#include "iceberg/iceberg_export.h"
+#include "iceberg/result.h"
+#include "iceberg/type_fwd.h"
+
+namespace iceberg {
+
+/// \brief A field schema partner to carry projection information.
+struct ICEBERG_EXPORT FieldProjection {
+  /// \brief How the field is projected.
+  enum class Kind {
+    /// \brief The field is projected from the source with possible conversion 
for
+    /// supported schema evolution.
+    kProjected,
+    /// \brief Metadata column whose value is generated on demand.
+    kMetadata,
+    /// \brief The field is a constant value (e.g. partition field value)
+    kConstant,
+    /// \brief The field is missing in the source and should be filled with 
default value.
+    kDefault,

Review Comment:
   This applies to a field that has set default value, regardless of its 
nullability. It should be checked before nullability though I didn't implement 
it since it is a v3 feature.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to