jonathanc-n commented on code in PR #1353:
URL: https://github.com/apache/iceberg-rust/pull/1353#discussion_r2098930807


##########
crates/iceberg/src/transaction/snapshot.rs:
##########
@@ -307,6 +308,11 @@ impl<'a> SnapshotProduceAction<'a> {
             .await?;
         let next_seq_num = 
self.tx.current_table.metadata().next_sequence_number();
 
+        snapshot_produce_operation.validate(

Review Comment:
   Is this validate function implemented? Should we hold off on the validation 
logic and add an API for retrying the operation with the new metadata. We can 
change this pull request to just add `validation_history` and 
`ancestors_between`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to