ajantha-bhat commented on code in PR #12450: URL: https://github.com/apache/iceberg/pull/12450#discussion_r2098476990
########## api/src/main/java/org/apache/iceberg/actions/ComputePartitionStats.java: ########## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.actions; + +import org.apache.iceberg.PartitionStatisticsFile; + +/** + * An action that computes and writes the partition statistics of an Iceberg table. Current snapshot + * is used by default. + */ +public interface ComputePartitionStats + extends Action<ComputePartitionStats, ComputePartitionStats.Result> { + /** + * Choose the table snapshot to compute partition stats. + * + * @param snapshotId long ID of the snapshot for which stats need to be computed + * @return this for method chaining + */ + ComputePartitionStats snapshot(long snapshotId); Review Comment: > I think the action is the delegate for the Procedure I don't think it is a strict guideline. Procedures are just a way to provide functionality from SQL. It can combine one or more APIs. Added the force compute. I agree that SQL user need a way to clear stats for force compute incase of corruption (even though it is very rare) without depending on APIs. I was neutral about adding it to the spark action as users of spark action already have API access. But I want to move forward with this work. So, I have added it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
