mxm commented on code in PR #13086:
URL: https://github.com/apache/iceberg/pull/13086#discussion_r2097491656
##########
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TaskResultAggregator.java:
##########
@@ -87,16 +92,18 @@ public void processElement2(StreamRecord<Exception>
streamRecord) {
@Override
public void processWatermark(Watermark mark) throws Exception {
- TaskResult response = new TaskResult(taskIndex, startTime,
exceptions.isEmpty(), exceptions);
- output.collect(new StreamRecord<>(response));
- LOG.info(
- "Aggregated result for table {}, task {}[{}] is {}",
- tableName,
- taskName,
- taskIndex,
- response);
- exceptions.clear();
- startTime = 0L;
+ if (startTime != 0L) {
Review Comment:
I think we should either perform a null check here if we stick with `Long`
for startTime, or change the type to `long`. The latter will have the advantage
that we don't even need to add the `open()` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
