pvary commented on code in PR #12528:
URL: https://github.com/apache/iceberg/pull/12528#discussion_r2095692340
##########
core/src/main/java/org/apache/iceberg/PartitionsTable.java:
##########
@@ -290,27 +297,25 @@ void update(ContentFile<?> file, Snapshot snapshot) {
if (snapshot != null) {
long snapshotCommitTime = snapshot.timestampMillis() * 1000;
if (this.lastUpdatedAt == null || snapshotCommitTime >
this.lastUpdatedAt) {
+ this.specId = file.specId();
+
Review Comment:
I don't get this change.
Why is it good to only use the `file.specId` then the times are ordered?
IIRC there is no guarantees on the values of the timestamps, so this could
cause unexpected behavior
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
