huaxingao commented on PR #12260: URL: https://github.com/apache/iceberg/pull/12260#issuecomment-2888092503
@wypoon Thanks for the PR — the changes look good to me. I have a question about the tests. It seems that a test like testReadStreamWithMaxRows2() would pass with both the original implementation (using readConf.maxRecordsPerMicroBatch()) and the new logic (using getMaxRows(readLimit)), since both return the same static value. Shall we add a test that would fail under the old implementation but pass with the new one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
