lirui-apache commented on PR #11196: URL: https://github.com/apache/iceberg/pull/11196#issuecomment-2886049825
It seems to me that the schema in PartitionSpec is ambiguous. IMO any schema that is compatible with the spec is fine, e.g. the schema when the spec is defined, or the current schema as long as it's still compatible. Would it be cleaner if we make this schema private to PartitionSpec? Evaluators needing a schema should get one in a more explicit way, e.g. get current schema from table or snapshot schema from the scan, depending on what they intend to do. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
