stevenzwu commented on code in PR #13010:
URL: https://github.com/apache/iceberg/pull/13010#discussion_r2087410850


##########
open-api/rest-catalog-open-api.py:
##########
@@ -991,6 +991,9 @@ class ValueMap(BaseModel):
 
 class DataFile(ContentFile):
     content: str = Field(..., const=True)
+    first_row_id: Optional[int] = Field(
+        None, alias='first-row-id', description='Starting row ID to assign to 
new rows'

Review Comment:
   I see. I think the spec description is a little more clear to me than the 
description from code.
   https://iceberg.apache.org/spec/#snapshots
   
   This is for the snpshot `first-row-id` field. but the concept is the same 
and hence description can be similar.
   ```
   first-row-id The first _row_id assigned to the first row in the first data 
file in the first manifest, see [Row 
Lineage](https://iceberg.apache.org/spec/#row-lineage)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to