kevinjqliu commented on code in PR #1998:
URL: https://github.com/apache/iceberg-python/pull/1998#discussion_r2087231294
##########
pyiceberg/catalog/rest/__init__.py:
##########
@@ -678,7 +679,16 @@ def list_tables(self, namespace: Union[str, Identifier])
-> List[Identifier]:
@retry(**_RETRY_ARGS)
def load_table(self, identifier: Union[str, Identifier]) -> Table:
- response = self._session.get(self.url(Endpoints.load_table,
prefixed=True, **self._split_identifier_for_path(identifier)))
+ params = {}
+ if mode := self.properties.get(SNAPSHOT_LOADING_MODE):
+ if mode in {"all", "refs"}:
+ params["snapshots"] = mode
+ else:
+ raise ValueError("Invalid snapshot-loading-mode: {}")
Review Comment:
corresponding REST spec
https://github.com/apache/iceberg/blob/5d2230ead79da64a8c871a02eb1304a94aaece5c/open-api/rest-catalog-open-api.yaml#L951-L962
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
