nastra commented on code in PR #13038:
URL: https://github.com/apache/iceberg/pull/13038#discussion_r2086462114
##########
spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/data/TestHelpers.java:
##########
@@ -561,21 +556,20 @@ private static void assertEqualsLists(
private static void assertEqualsMaps(
String prefix, Types.MapType type, MapData expected, Map<?, ?> actual) {
if (expected == null || actual == null) {
- Assert.assertEquals(prefix, expected, actual);
+ assertThat(actual).as(prefix).isEqualTo(expected);
} else {
Type keyType = type.keyType();
Type valueType = type.valueType();
ArrayData expectedKeyArray = expected.keyArray();
ArrayData expectedValueArray = expected.valueArray();
- Assert.assertEquals(prefix + " length", expected.numElements(),
actual.size());
+ assertThat(actual).as(prefix + "
length").hasSize(expectedKeyArray.numElements());
for (int e = 0; e < expected.numElements(); ++e) {
Object expectedKey = getValue(expectedKeyArray, e, keyType);
Object actualValue = actual.get(expectedKey);
if (actualValue == null) {
- Assert.assertEquals(
- prefix + ".key=" + expectedKey + " has null",
- true,
- expected.valueArray().isNullAt(e));
+ assertThat(true)
Review Comment:
this assertions looks a bit weird. I would suggest to rewrite this to
`assertThat(expected.valueArray().isNullAt(e)).as("%s.key=%s has null", prefix,
expectedKey).isTrue();`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
