zhjwpku commented on code in PR #97:
URL: https://github.com/apache/iceberg-cpp/pull/97#discussion_r2086473118
##########
src/iceberg/name_mapping.h:
##########
@@ -40,10 +40,10 @@ struct ICEBERG_EXPORT MappedField {
std::unordered_set<std::string> names;
/// \brief An optional Iceberg field ID used when a field's name is present
in `names`.
/// TODO(gangwu): check if we need to make it optional
Review Comment:
The TODO note can be deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
