RussellSpitzer commented on code in PR #12999:
URL: https://github.com/apache/iceberg/pull/12999#discussion_r2085373090


##########
spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/TestSparkWriteConf.java:
##########
@@ -486,6 +486,36 @@ public void testDeleteFileWriteConf() {
     }
   }
 
+  @Test
+  public void testExtraSnapshotMetadataReflectsSessionConfig() {
+    withSQLConf(
+        ImmutableMap.of("spark.sql.iceberg.snapshot-property.test-key", 
"test-value"),

Review Comment:
   Trivial nit: "test-value" -> "session-value" so it mimics the test below. 
This is the tiniest of nits so feel free to ignore.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to