amogh-jahagirdar commented on code in PR #13022:
URL: https://github.com/apache/iceberg/pull/13022#discussion_r2084813321
##########
build.gradle:
##########
@@ -120,6 +120,9 @@ allprojects {
repositories {
mavenCentral()
mavenLocal()
+ maven {
+ url
"https://repository.apache.org/content/repositories/orgapachespark-1481/";
+ }
Review Comment:
> I think it is not a good practice to depend on RC on main branch. Why
don't we continue the development in the separate branch till the official
release available?
@ajantha-bhat It's true that we'd have a dependency on an RC on main but
there's a benefit to being able to develop on top of it for any new
integrations (e.g. for V3 for example) while the RC is still going because we
don't expect those dependent features to fundamentally change between RC and
release. Keep in mind the defaultSparkVersion and any infra like benchmarking
will still default to 3.5 until the official release.
The main challenge is that continuing development in the separate branch
means that an individual needs to keep rebasing and evaluating if a change
needs to be kept in sync with 4.0 with any intermediate changes to 3.4/3.5.
Merging the initial means that every subsequent change to Iceberg-Spark puts it
on the author of that change to keep it in sync, which is more narrow and that
author will have a lot more context.
Combining that with the previous point about new integrations simply means
we can safely and reasonably iterate on 4.0 integration until the official
release rather than an individual just wait for all of that while
rebasing/keeping in sync.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
