liurenjie1024 commented on code in PR #1302:
URL: https://github.com/apache/iceberg-rust/pull/1302#discussion_r2084367356
##########
crates/catalog/glue/tests/glue_catalog_test.rs:
##########
@@ -105,7 +105,7 @@ async fn set_test_namespace(catalog: &GlueCatalog,
namespace: &NamespaceIdent) -
Ok(())
}
-fn set_table_creation(location: impl ToString, name: impl ToString) ->
Result<TableCreation> {
+fn set_table_creation(name: impl ToString) -> Result<TableCreation> {
Review Comment:
nit: Would it be better to make `locaation` an `Option` than removing it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
