liurenjie1024 commented on issue #172: URL: https://github.com/apache/iceberg-rust/issues/172#issuecomment-2871933855
> I'm not sure if we'd like to ensure that FileIO is serializable. The end application (e.g. Sail) would likely have their own configuration systems and their own way for distributed coordination. The only thing they need is a way to construct FileIO in memory and inject their own storage implementations. This makes the Iceberg library more flexible with a separation of concerns. It also unblocks use cases such as automatic credential rotation, where credential management is a implementation detail inside dyn ObjectStore without passing in something like S3Config to Storage or FileIO. Seems that in this case it would be better to make `FileIO` a trait object rather a struct. > Maybe this topic is more suitable as a separate GitHub issue? +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
