tomtongue commented on PR #13021: URL: https://github.com/apache/iceberg/pull/13021#issuecomment-2870850642
> @tomtongue > > Hello, Apologies for the repeated question..... > > I successfully ran `./gradlew spotlessApply` and `./gradlew build -x test -x integrationTest`, and then submitted a pull request. > > However, the CI/CD pipeline is showing a failure. Is there possibly something wrong? > > Should I have run `./gradlew build` completely before submitting the PR, or should I wait for feedback from the maintainer? > > I would sincerely appreciate any feedback regarding this and the code I submitted in the PR. > > Thank you. The `-x` option in `./gradlew build -x test -x integrationTest` skips the unit and integration tests. So if you check whether your changes works well on your local, please set a specific test first, like`./gradlew :iceberg-flink:iceberg-flink-2.0:test --tests "org.apache.iceberg.flink.source.TestIcebergSourceFailover"` etc. Then, run the whole or relevant flink tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
