mxm commented on PR #12996: URL: https://github.com/apache/iceberg/pull/12996#issuecomment-2866957785
I've pushed an update to address the comments. On the name discussion: I think this is all just convention. Every community has its own styles. I don't think either way makes more sense. `upsertMode` makes perfect sense to me, `isUpsert` not so much because not every record produces an upsert, but `isUpsertMode` makes just as much sense, even though the boolean type is next to the name. The most important reason is consistency. All existing Flink Iceberg sinks use that name. I don't see a strong case to deviate from it. I did rename `mode` to `distributionMode` and `spec` to `ugpradeSpec`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
