stevenzwu commented on issue #12971: URL: https://github.com/apache/iceberg/issues/12971#issuecomment-2864446931
let me confirm the problem. The problem is that the identifier fields rule (e.g. excluding FLOAT and DOUBLE types) is not enforced? Yes, I would agree that it should be enforced, as floating numbers can exhibit differences across platforms and hence are not suitable for. > It seems that [DeleteWriteBuilder::buildEqualityWriter](https://github.com/apache/iceberg/blob/696a72c0f88c3af1096e716b196f1609da34e50d/orc/src/main/java/org/apache/iceberg/orc/ORC.java#L605C40-L605C59) for all the formats should check on the constraints based on the schema and equalityFieldIds But I am not sure if the enforcment should be done by Parquet/Orc writer. It should probably be enforced by the table DDL when setting the identifier/equality fields. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
