wypoon commented on PR #13006: URL: https://github.com/apache/iceberg/pull/13006#issuecomment-2863895232
> @pan3793 I think this over, actually, the key to preserve history is what happens in step 1, right? Ideally, I should have 3 commits, but as long as I have 1 and 2, it's OK to have more than 3 commits? > > 1. [Move 3.5 as 4.0] > 2. [Copy back 4.0 as 3.5] > 3. [initial support for Spark 4.0] I know this is abandoned, but for future reference, why do you want to have more than 3 commits? If you have 1 and 2 for sure, then to have more than 3 commits means you want to spread the initial support for the new version over several commits? What benefit would that bring? For a PR itself, the initial support may well occur over many commits due to iterations, but for merging into the repo, we'd want a single commit for 3. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
