rdblue commented on code in PR #12987:
URL: https://github.com/apache/iceberg/pull/12987#discussion_r2079921543


##########
open-api/rest-catalog-open-api.py:
##########
@@ -399,6 +406,16 @@ class EnableRowLineageUpdate(BaseUpdate):
     action: str = Field('enable-row-lineage', const=True)
 
 
+class AddEncryptionKey(BaseUpdate):
+    action: str = Field('add-encryption-key', const=True)
+    encryption_key: Optional[EncryptedKey] = Field(None, 
alias='encryption-key')

Review Comment:
   Good catch. I updated the spec to make this required.



##########
open-api/rest-catalog-open-api.py:
##########
@@ -399,6 +406,16 @@ class EnableRowLineageUpdate(BaseUpdate):
     action: str = Field('enable-row-lineage', const=True)
 
 
+class AddEncryptionKey(BaseUpdate):
+    action: str = Field('add-encryption-key', const=True)
+    encryption_key: Optional[EncryptedKey] = Field(None, 
alias='encryption-key')
+
+
+class RemoveEncryptionKey(BaseUpdate):
+    action: str = Field('remove-encryption-key', const=True)
+    key_id: Optional[str] = Field(None, alias='key-id')

Review Comment:
   Also fixed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to