dramaticlly commented on code in PR #12228:
URL: https://github.com/apache/iceberg/pull/12228#discussion_r2078357142
##########
core/src/test/java/org/apache/iceberg/hadoop/TestHadoopCatalog.java:
##########
@@ -676,6 +677,27 @@ public void testRegisterExistingTable() throws IOException
{
assertThatThrownBy(() -> catalog.registerTable(identifier,
metadataLocation))
.isInstanceOf(AlreadyExistsException.class)
.hasMessage("Table already exists: a.t1");
+ assertThatThrownBy(() -> catalog.registerTable(identifier,
metadataLocation, false))
+ .isInstanceOf(AlreadyExistsException.class)
+ .hasMessage("Table already exists: a.t1");
+ assertThat(catalog.dropTable(identifier)).isTrue();
+ }
+
+ @Test
+ public void testRegisterAndOverwriteExistingTable() throws IOException {
Review Comment:
yeah I think this is a good point as Hadoop table operations always look for
highest version file in metadata root.
I feel like maybe we shall not support register table for Hadoop catalog at
all, let me override and try throw UnsupportedOperationException in
register-table instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
