jonathanc-n commented on code in PR #1297:
URL: https://github.com/apache/iceberg-rust/pull/1297#discussion_r2078291461
##########
crates/catalog/memory/src/catalog.rs:
##########
@@ -53,6 +53,19 @@ impl MemoryCatalog {
warehouse_location,
}
}
+
+ /// Register an existing table in the memory catalog.
+ pub async fn register_existing_table(
Review Comment:
We should have an issue to add this for the other catalogs. Should we add
this to the `Catalog` trait?
##########
crates/integrations/datafusion/src/table/mod.rs:
##########
@@ -130,8 +131,19 @@ impl TableProvider for IcebergTableProvider {
filters: &[Expr],
_limit: Option<usize>,
) -> DFResult<Arc<dyn ExecutionPlan>> {
+ // Get the latest table metadata from the catalog if it exists
Review Comment:
we can change to a refresh function similar to python + java implementation
##########
crates/integrations/datafusion/src/table/mod.rs:
##########
@@ -43,6 +43,8 @@ pub struct IcebergTableProvider {
snapshot_id: Option<i64>,
/// A reference-counted arrow `Schema`.
schema: ArrowSchemaRef,
+ /// A reference to the catalog that this table provider belongs to.
+ catalog: Option<Arc<dyn Catalog>>,
Review Comment:
This is nice, we need this for future transactions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
