zeroshade commented on PR #423: URL: https://github.com/apache/iceberg-go/pull/423#issuecomment-2858895971
> Where does it need to be transformed to a string? The implementations of DayTransform.Transformer, DayTransform.Apply, and DayTransform.ToHumanStr all return/require int32 values, not Date. So this feels very inconsistent. That's a good point, you're right. I forgot about the `ToHumanStr` function which handles the only case where we'd need to do that conversion to string. So you're probably right, we can safely shift the result type to be int32. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
