zeroshade commented on code in PR #422:
URL: https://github.com/apache/iceberg-go/pull/422#discussion_r2076439116
##########
table/table.go:
##########
@@ -230,12 +228,12 @@ func deleteOldMetadata(fs io.IO, baseMeta, newMeta
Metadata) error {
for _, file := range toRemove {
if err := fs.Remove(file); err != nil {
- return fmt.Errorf("failed to delete old
metadata file %s: %w", file, err)
+ //Log the error instead of raising it when
deleting old metadata files, as an external entity like a compactor may have
already deleted them
+ fmt.Printf("Warning: Failed to delete old
metadata file %s: %v", file, err)
Review Comment:
use `log.Printf` so that we can easily update and manipulate this in the
future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
