zeroshade commented on code in PR #421:
URL: https://github.com/apache/iceberg-go/pull/421#discussion_r2076436060
##########
table/metadata.go:
##########
@@ -1145,6 +1146,9 @@ func (m *metadataV1) UnmarshalJSON(b []byte) error {
type Alias metadataV1
aux := (*Alias)(m)
+ // Set LastColumnId to -1 to indicate that it is not set as
LastColumnId = 0 is a valid value for when no schema is present
+ aux.LastColumnId = -1
Review Comment:
`last-column-id` is a required attribute, so it should never be missing. So
I don't think we need to do this
##########
table/metadata.go:
##########
@@ -1190,6 +1194,9 @@ func (m *metadataV2) UnmarshalJSON(b []byte) error {
type Alias metadataV2
aux := (*Alias)(m)
+ // Set LastColumnId to -1 to indicate that it is not set as
LastColumnId = 0 is a valid value for when no schema is present
+ aux.LastColumnId = -1
Review Comment:
same comment as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
