rdblue commented on code in PR #12982: URL: https://github.com/apache/iceberg/pull/12982#discussion_r2076017662
########## format/spec.md: ########## @@ -1680,6 +1680,23 @@ Row-level delete changes: * These position delete files must be merged into the DV for a data file when one is created * Position delete files that contain deletes for more than one data file need to be kept in table metadata until all deletes are replaced by DVs +Row lineage changes: + +* Writers must set the table's `next-row-id` and use the existing `next-row-id` as the `first-row-id` to create a new snapshot + * When a table is upgraded to v3, `next_row_id` should be initialized to 0 + * It is recommended to increment `next-row-id` by the total `added_rows_count` and `existing_rows_count` of all manifests assigned a `first_row_id` Review Comment: Added. And I copied this for manifest lists as well ("at least the number of newly assigned row ids in each manifest") -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org