petern48 commented on code in PR #12951:
URL: https://github.com/apache/iceberg/pull/12951#discussion_r2075729044
##########
site/nav.yml:
##########
@@ -22,8 +22,7 @@ nav:
- Hive: hive-quickstart.md
- Docs:
- nightly: '!include docs/docs/nightly/mkdocs.yml'
- - latest: '!include docs/docs/latest/mkdocs.yml'
- - 1.9.0: '!include docs/docs/1.9.0/mkdocs.yml'
+ - 1.9.0 (latest): '!include docs/docs/1.9.0/mkdocs.yml'
Review Comment:
The idea behind my change is that `1.9.0` represents `latest`. I know it's
not the most elegant solution, but again I'm not aware of how we can get that
value of `1.9.0` programmatically. Alternatively, we could label it as follows
```diff
- - 1.9.0 (latest): '!include docs/docs/1.9.0/mkdocs.yml'
+ - 1.9.0 (latest): '!include docs/docs/latest/mkdocs.yml'
```
but I personally thought it would be less error-prone to write `1.9.0`
instead of `latest`. I think these are manually updated anyway, so I figured
this would be reasonable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
