Guosmilesmile commented on code in PR #12810: URL: https://github.com/apache/iceberg/pull/12810#discussion_r2074561987
########## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/api/ZkLockFactory.java: ########## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.flink.maintenance.api; + +import java.io.IOException; +import java.util.concurrent.TimeUnit; +import org.apache.curator.framework.CuratorFramework; Review Comment: I found that the following packages include Curator, but only at the compile stage. When packaging `iceberg-flink-runtime-1.19-1.8.1.jar`, the Curator dependency is not included. ``` org.apache.flink:flink-connector-test-utils:1.20.1 org.apache.hadoop:hadoop-common:3.4.1 org.apache.hadoop:hadoop-minicluster:3.4.1 org.apache.hive:hive-exec:2.3.10 org.apache.hive:hive-metastore:2.3.10 ``` So, if we want to use `zkLock`, we need to add the Curator dependency in the Flink lib or business package. Currently, if we want to use `JdbcCatalog`, we need to add `mysql-connector-java-8.0.30.jar` to the lib. In my view if we want to use `jdbcLock`, we also need to add the dependency myself If you have better suggestions, please let me know. Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
