nastra commented on code in PR #12972:
URL: https://github.com/apache/iceberg/pull/12972#discussion_r2073512141
##########
aws/src/integration/java/org/apache/iceberg/aws/s3/TestS3MultipartUpload.java:
##########
@@ -63,7 +64,13 @@ public static void beforeClass() {
properties = new S3FileIOProperties();
properties.setMultiPartSize(S3FileIOProperties.MULTIPART_SIZE_MIN);
properties.setChecksumEnabled(true);
- io = new S3FileIO(() -> s3, properties);
+ io = new S3FileIO(() -> s3);
+ io.initialize(
+ ImmutableMap.of(
+ S3FileIOProperties.MULTIPART_SIZE,
+ Integer.toString(S3FileIOProperties.MULTIPART_SIZE_MIN),
+ S3FileIOProperties.CHECKSUM_ENABLED,
+ "true"));
Review Comment:
Since this is for tests there's really no benefit in using
`Boolean.TRUE.toString()` vs the plain string
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
