nastra commented on PR #11476: URL: https://github.com/apache/iceberg/pull/11476#issuecomment-2851089832
> Hi team, may I ask a dummy question? I'm wondering if this is the official java implementation for deletion vector mentioned at https://iceberg.apache.org/puffin-spec/#deletion-vector-v1-blob-type? In other words, if I want to write deletion vector (in iceberg V3), should I use `BaseDVFileWriter`? > > My confusion lies in: > > * I see serialized blob should contain magic sequence "D1 D3 39 64", but I didn't find it anywhere > * The spec mentions blob contains CRC32 for magic bytes and serialized bytes, I also don't find it > > Appreciate any answer! I could tell iceberg is evolving really fast, so as a newcomer I'm kinda lost in the (multiple) proposals and different versions of implementation. @dentiny yes this repository contains the java implementation. You might want to start browsing the code around `BitmapPositionDeleteIndex` / `RoaringPositionBitmap` / `BaseDVFileWriter`, which should contain the info you're looking for. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
