ajantha-bhat commented on PR #12060:
URL: https://github.com/apache/iceberg/pull/12060#issuecomment-2850881632
Hi @rdblue, @danielcweeks, @RussellSpitzer:
I didn't see tests for parquet metadata in `core` module with `InternalData`
as of now. Background is I used `InternalData` for partition stats in #12946.
I tried adding parquet dependency for tests but it is a circular dependency.
Hence, I had to keep tests at `iceberg-data` and source code at
`iceberg-core`. I can move code also to `iceberg-data` but it is a core
functionality.
So, In future when `core` module writes metadata in parquet (v4), are we
gonna keep tests in `iceberg-parquet` or `iceberg-data` and code in
`iceberg-core`? What are your thoughts on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
