nastra commented on code in PR #12799:
URL: https://github.com/apache/iceberg/pull/12799#discussion_r2073097960
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java:
##########
@@ -164,40 +164,32 @@ public S3FileIO(
S3FileIOProperties s3FileIOProperties) {
this.s3 = s3;
this.s3Async = s3Async;
- this.s3FileIOProperties = s3FileIOProperties;
Review Comment:
yes I agree, this is also the only reason why we're exposing the underlying
properties from `S3FileIOProperties` / `GCPProperties`. I'll open a separate PR
to deprecate this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
