loicalleyne commented on code in PR #412:
URL: https://github.com/apache/iceberg-go/pull/412#discussion_r2072246956


##########
schema.go:
##########
@@ -1488,6 +1488,10 @@ func sanitizeName(n string) string {
        return b.String()
 }
 
+func desanitizeName(n string) string {
+       return strings.ReplaceAll(n, "_x2E", ".")
+}

Review Comment:
   It's the MVP fix for the issue reported, the regex is too greedy and can 
potentially capture more characters than it should. I'm working on the switch 
to using field ID for another PR. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to