flyrain commented on PR #12406: URL: https://github.com/apache/iceberg/pull/12406#issuecomment-2848156238
Thanks for the discussion. I'm leaning toward keeping proxy separate from `authManager`. The tiny bit we’re adding(an HTTP proxy) is more on the transport-level wiring for the HTTP client. Things like proxy settings, TLS, and timeouts normally belong to the HTTP transport layer and control how HTTP works. `AuthManager`, on the other hand, handles app-level auth policies such as user id, token, and authorization logic. The line can blur in practice, but it’s important to keep a clean boundary in our code so we don’t end up with two overlapping ways to configure different layers, which usually leads to messiness and bugs. With that, +1 on the method proposed here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
