AdamGS opened a new pull request, #1286:
URL: https://github.com/apache/iceberg-rust/pull/1286
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
- Closes #.
## What changes are included in this PR?
Mostly dependency changes with very minor code changes. There are two open
things in my mind:
1. Seems like the `AsyncFileRead` trait changed and the options struct is
very private, so maybe there's some other type that can be pulled from
`parquet-rs` to replace `ArrowFileReader`. IDK if its desirable but I do think
it might make sense to make some changes
2. There some dependency issue I'm not sure is resolvable without bumping
the msrv, right now if you run CI on this branch that check will fail with:
```
error[E0599]: no function or associated item named `into_compile_error`
found for struct `syn::Error` in the current scope
-->
/Users/adamgs/.cargo/registry/src/index.crates.io-6f17d22bba15001f/motore-macros-0.4.0/src/lib.rs:38:28
|
38 | return syn::Error::into_compile_error(err).into();
| ^^^^^^^^^^^^^^^^^^ function or associated
item not found in `syn::Error`
|
note: if you're trying to build a new `syn::Error` consider using one of the
following associated functions:
syn::Error::new
syn::Error::new_spanned
-->
/Users/adamgs/.cargo/registry/src/index.crates.io-6f17d22bba15001f/syn-1.0.44/src/error.rs:133:5
|
133 | pub fn new<T: Display>(span: Span, message: T) -> Self {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
...
157 | pub fn new_spanned<T: ToTokens, U: Display>(tokens: T, message: U)
-> Self {
|
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
help: there is a method `to_compile_error` with a similar name, but with
different arguments
-->
/Users/adamgs/.cargo/registry/src/index.crates.io-6f17d22bba15001f/syn-1.0.44/src/error.rs:193:5
|
193 | pub fn to_compile_error(&self) -> TokenStream {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
```
I'm leaving it here until I have some more time to play around with these
issues and to get some feedback if anything here is actually welcome.
<!--
Provide a summary of the modifications in this PR. List the main changes
such as new features, bug fixes, refactoring, or any other updates.
-->
## Are these changes tested?
<!--
Specify what test covers (unit test, integration test, etc.).
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
