alamb commented on issue #1277: URL: https://github.com/apache/iceberg-rust/issues/1277#issuecomment-2845952969
I don't think it needs an expansion in Java -- the Parquet type system and Iceberg type systems are different than Arrow What I think needs to happen is to extend this `match` expression to handle Dictionary types https://github.com/apache/iceberg-rust/blob/b4bc6dd15ae4f7a4b1c9ce555e3458089a83e228/crates/iceberg/src/arrow/schema.rs#L117 I believe the visitor should probably just use the Dictionary's value type; Something like: ```rust match r#type { ... // use the inner type of the dictionary DataType::Dictionary(_key_type, value_type) => visit_type(&value_type, visitor) ... } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
