danielcweeks commented on code in PR #12881:
URL: https://github.com/apache/iceberg/pull/12881#discussion_r2070444738
##########
gcp/src/main/java/org/apache/iceberg/gcp/GCPProperties.java:
##########
@@ -61,6 +62,8 @@ public class GCPProperties implements Serializable {
*/
public static final int GCS_DELETE_BATCH_SIZE_DEFAULT = 50;
+ private final Map<String, String> allProperties;
Review Comment:
Do we really need to keep all the properties? The goal was to no copy all
properties when we should only need the FileIO specific properties (though it
looks like all properties were added to the FileIO as well which is
questionable)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
