zhjwpku opened a new pull request, #90:
URL: https://github.com/apache/iceberg-cpp/pull/90

   FetchContent_MakeAvailable generate a <lowercaseName>_SOURCE_DIR[1], for 
arrow it's arrow_SOURCE_DIR. arrow use a internal arrow_SOURCE_DIR to set its 
THIRDPARTY_DIR[2].
   
   The generated arrow_SOURCE_DIR overwrite the arrow's interal 
arrow_SOURCE_DIR, causing the following build error:
   
   CMake Error at 
build/_deps/arrow-src/cpp/cmake_modules/ThirdpartyToolchain.cmake:449 (file):
     file STRINGS file
     
"/Users/zhjwpku/zhjwpku/iceberg-cpp/build/_deps/arrow-src/thirdparty/versions.txt"
     cannot be read.
   
   Fix this issue by renaming fetchcontent_declare name from Arrow to 
VendoredArrow.
   
   [1] 
https://cmake.org/cmake/help/latest/module/FetchContent.html#command:fetchcontent_makeavailable
   [2] 
https://github.com/apache/arrow/blob/main/cpp/cmake_modules/ThirdpartyToolchain.cmake#L368


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to