amogh-jahagirdar commented on code in PR #12928:
URL: https://github.com/apache/iceberg/pull/12928#discussion_r2069768082
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRowLevelOperationsWithLineage.java:
##########
@@ -91,7 +91,6 @@ public void beforeEach() {
assumeThat(formatVersion).isGreaterThanOrEqualTo(3);
// ToDo: Remove these as row lineage inheritance gets implemented in the
other readers
assumeThat(fileFormat).isEqualTo(FileFormat.PARQUET);
- assumeThat(vectorized).isFalse();
Review Comment:
I should probably have an additional test which creates a lot of records
(more than a single batch in a vectorized read), performs a modification on
records with even IDs and asserts the row lineage state. Right now we're
effectively just testing a single batch within this test. Theoretically
everything should just work but it'll be better to have an explicit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
