aihuaxu commented on code in PR #12916:
URL: https://github.com/apache/iceberg/pull/12916#discussion_r2069721457
##########
parquet/src/test/java/org/apache/iceberg/parquet/TestVariantReaders.java:
##########
@@ -1455,70 +1454,12 @@ private static void checkShreddedType(Type
shreddedType) {
}
private static Type shreddedPrimitive(PrimitiveTypeName primitive) {
Review Comment:
Seems to make sense to use
`ParquetSchemaProducer.shreddedPrimitive(primitive)` directly rather than
creating a new method here. Same for shreddedPrimitive(PrimitiveTypeName
primitive, LogicalTypeAnnotation annotation), checkField(GroupType fieldType),
objectFields(GroupType... fields) below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
