amogh-jahagirdar commented on code in PR #12863:
URL: https://github.com/apache/iceberg/pull/12863#discussion_r2069409094
##########
core/src/main/java/org/apache/iceberg/io/BaseTaskWriter.java:
##########
@@ -345,12 +348,17 @@ private void closeCurrent() throws IOException {
currentWriter.close();
if (currentRows == 0L) {
- try {
- io.deleteFile(currentFile.encryptingOutputFile());
- } catch (UncheckedIOException e) {
- // the file may not have been created, and it isn't worth
failing the job to clean up,
- // skip deleting
- }
+ // the file may not have been created or cannot be deleted, and it
isn't worth failing
+ // the job to clean up, skip deleting
+ Tasks.foreach(currentFile.encryptingOutputFile())
+ .suppressFailureWhenFinished()
+ .onFailure(
+ (file, exc) ->
+ LOG.warn(
+ "Failed to delete the empty file during writer
clean up: {}",
Review Comment:
Nit: Not sure the fact that it's an empty file is really useful in the log
(maybe, as a user if you see the warn log that it's empty you're less concerned
about how much dangling storage is there). I'd probably leave the "the empty"
out but I'm also OK with it as it is since it's probably such a rare case that
the log will be fired off.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
