sdd commented on PR #982: URL: https://github.com/apache/iceberg-rust/pull/982#issuecomment-2843018757
> Thanks @sdd for this pr. There are some missing points in current design. Also I would suggest not putting too much in `DeleteFilterManager`. I suppose `DeleterFilterManager` acting more like a delete loader, which manages the io and caching of record batch. The actual filtering part, could delegate to `DeleteFilter`, WDYT? I think a good reference implementation is java's DeleteFilter, see https://github.com/apache/iceberg/blob/af8e3f5a40f4f36bbe1d868146749e2341471586/data/src/main/java/org/apache/iceberg/data/DeleteFilter.java#L50 I've refactored as you suggested and you're right, it is a better design. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
