nastra commented on code in PR #12930:
URL: https://github.com/apache/iceberg/pull/12930#discussion_r2066869310
##########
core/src/main/java/org/apache/iceberg/io/StorageCredential.java:
##########
@@ -21,26 +21,19 @@
import java.io.Serializable;
import java.util.Map;
import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
-import org.apache.iceberg.util.SerializableMap;
-import org.immutables.value.Value;
-@Value.Immutable
public interface StorageCredential extends Serializable {
String prefix();
- SerializableMap<String, String> config();
+ Map<String, String> config();
- @Value.Check
default void validate() {
Preconditions.checkArgument(!prefix().isEmpty(), "Invalid prefix: must be
non-empty");
Preconditions.checkArgument(!config().isEmpty(), "Invalid config: must be
non-empty");
}
static StorageCredential create(String prefix, Map<String, String> config) {
- return ImmutableStorageCredential.builder()
- .prefix(prefix)
- .config(SerializableMap.copyOf(config))
Review Comment:
a `SerializableMap` will be created internally by the builder
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
