nastra commented on code in PR #12922:
URL: https://github.com/apache/iceberg/pull/12922#discussion_r2066491149


##########
site/docs/how-to-release.md:
##########
@@ -323,19 +323,23 @@ Please follow the instructions on the GitHub repository 
in the [`README.md` in t
 
 #### Versioned Docs
 
-The versioned docs in the source tarball are located under `site/docs`. Check 
out the `docs` branch in the `iceberg` repo and copy
-the versioned docs over:
+The versioned docs is located in the `docs` directory within the source of the 
released tag (e.g. 
https://github.com/apache/iceberg/tree/apache-iceberg-1.8.0/docs). 
+Check out the `docs` branch in the `iceberg` repo and copy the versioned docs 
over:
 
 ```
-cp -R apache-iceberg-1.8.0/site/docs 1.8.0
+cp -R iceberg/docs 1.8.0
 ```
 
 Once this is done, create a PR against the `docs` branch containing the 
changes under the `1.8.0` folder, similar to 
https://github.com/apache/iceberg/pull/12411.
 
+Note: Update the site name from `docs/latest` to `docs/1.8.0` in the copied 
`mkdocs.yml` file.
+
 #### Versioned Javadoc
 
 Navigate to the source tarball and generate Javadoc:
 
+Note: Make sure that JDK version with Gradle is 17 or above.

Review Comment:
   ```suggestion
   Note: When generating Javadoc, make sure to use JDK 17+.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to