pvary commented on PR #12810: URL: https://github.com/apache/iceberg/pull/12810#issuecomment-2838188752
> @pvary I have changed the code based on the comments. However, there is still one issue we need to discuss: whether to keep the InstanceId. > > The InstanceId is mainly used to solve the problem of whether a retry was successfully done by self. Even though we have given the retries to the curator framework, I am not completely sure if the framework will work as expected in this case, so I kept the InstanceId. > > If it is not needed, I think we can remove it. This problem appears a lot for the users, so there is some already existing solution for this. See: https://curator.apache.org/docs/recipes-shared-lock Also this seems like a typical problem for distributed system. Could we use one of the existing curator recepies? https://curator.apache.org/docs/recipes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
