Re: [PR] Flink: Add lockFactory open in LockRemover [iceberg]

[via GitHub]

pvary commented on code in PR #12900:
URL: https://github.com/apache/iceberg/pull/12900#discussion_r2065478202


##########
flink/v2.0/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/TestLockRemover.java:
##########
@@ -294,24 +294,33 @@ private void processAndCheck(
   }
 
   private static class TestingLockFactory implements TriggerLockFactory {
+
+    private boolean open = false;
+
     @Override
     public void open() {
-      // Do nothing
+      open = true;
     }
 
     @Override
     public Lock createLock() {
+      if (!open) {
+        throw new IllegalStateException("Lock factory not open");
+      }

Review Comment:
   Nit: newline 



##########
flink/v2.0/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/TestLockRemover.java:
##########
@@ -294,24 +294,33 @@ private void processAndCheck(
   }
 
   private static class TestingLockFactory implements TriggerLockFactory {
+
+    private boolean open = false;
+
     @Override
     public void open() {
-      // Do nothing
+      open = true;
     }
 
     @Override
     public Lock createLock() {
+      if (!open) {
+        throw new IllegalStateException("Lock factory not open");
+      }
       return LOCK;
     }
 
     @Override
     public Lock createRecoveryLock() {
+      if (!open) {
+        throw new IllegalStateException("Lock factory not open");
+      }

Review Comment:
   Nit: newline



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org