wypoon commented on issue #12878:
URL: https://github.com/apache/iceberg/issues/12878#issuecomment-2835877292

   @pvary I think this means that when using a Hive 4 HMS, you need to use a 
Hive 4 HMS client; it doesn't mean that the same Iceberg hive-metastore code 
cannot be run against both Hive 2 and Hive 4.
   This line in Iceberg's HiveTableOperations:
   ```
         Table table = metaClients.run(client -> client.getTable(database, 
tableName));
   ```
   will use a different `client` depending on the version of Hive you use, and 
the `client.getTable` call will be different depending on the version of Hive, 
right?
   ```
      Table getTable(@NotNull String dbName, @NotNull String tableName) throws 
TException {
   -    return client.get_table(dbName, tableName);
   +    GetTableRequest req = new GetTableRequest(dbName, tableName);
   +    return client.get_table_req(req).getTable();
      }
   ```
   
   If my understanding is correct, the work I'm doing is fine.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to