rdblue commented on code in PR #12512: URL: https://github.com/apache/iceberg/pull/12512#discussion_r2060986753
########## parquet/src/test/java/org/apache/iceberg/parquet/TestVariantReaders.java: ########## @@ -1327,7 +1327,7 @@ public void testArrayWithElementNullValueAndNullTypedValue() throws IOException VariantValue actualValue = actualVariant.value(); assertThat(actualValue.type()).isEqualTo(PhysicalType.ARRAY); assertThat(actualValue.asArray().numElements()).isEqualTo(1); - assertThat(actualValue.asArray().get(0)).isNull(); + VariantTestUtil.assertEqual(Variants.ofNull(), actualValue.asArray().get(0)); Review Comment: I think this could be a simpler assertion by checking an expected array against the actual, but this is okay, too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org