jbonofre commented on code in PR #12897:
URL: https://github.com/apache/iceberg/pull/12897#discussion_r2060454170
##########
api/src/main/java/org/apache/iceberg/PartitionField.java:
##########
@@ -19,26 +19,49 @@
package org.apache.iceberg;
import java.io.Serializable;
+import java.util.List;
+import java.util.stream.Collectors;
import org.apache.iceberg.relocated.com.google.common.base.Objects;
+import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
import org.apache.iceberg.transforms.Transform;
/** Represents a single field in a {@link PartitionSpec}. */
public class PartitionField implements Serializable {
- private final int sourceId;
+ private final List<Integer> sourceIds;
private final int fieldId;
private final String name;
private final Transform<?, ?> transform;
+ /**
+ * @deprecated since 1.10.0, will be removed in 2.0.0; use
PartitionField(sourceIds, fieldId,
+ * name, transform) instead.
+ */
+ @Deprecated
Review Comment:
That's a good point. The reason why I flagged deprecated is to "force" the
callers to use source-ids "style" (I don't deprecated in the builder as the
current transforms support only one argument).
I'm OK to remove the `@Deprecated` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
