jbonofre opened a new pull request, #12897: URL: https://github.com/apache/iceberg/pull/12897
Following the update on the spec regarding `source-id` and `source-ids` (thanks again @Fokko 😄 ), here's the PR to introduce `source-ids` field in partition spec. Some notes: 1. Internal representation is now based on `source-ids` 2. Serialization/deserialization supports `source-id` and `source-ids` elements in the json (exclusive), both populating `source-ids` internal representation (as `List<Integer>`) 3. The `TestPartitionSpecParser` is still testing `source-id`, but also `source-ids` parsing, and neither `source-id` and `source-ids` presence (throwing `IllegalArgumentException` in that case) 4. For backward compatibility (especially for the transforms), source id is still supported (using the first element in the internal representation) and some methods have been flagged as deprecated to encourage use of source ids. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
